Let crypto._cert_fingerprint pass bytes to load_pem_x509_certificate#77
Closed
zmousm wants to merge 1 commit intoIdentityPython:masterfrom
Closed
Let crypto._cert_fingerprint pass bytes to load_pem_x509_certificate#77zmousm wants to merge 1 commit intoIdentityPython:masterfrom
zmousm wants to merge 1 commit intoIdentityPython:masterfrom
Conversation
crypto._cert_fingerprint must ensure first parameter to load_pem_x509_certificate is bytes, as there are code paths which pass this as a string, such as crypto.from_keyspec -> crypto._load_keyspec -> crypto.XMLSecCryptoFromXML.__init__ -> crypto._cert_fingerprint
Author
|
The issue affecting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto._cert_fingerprintmust ensure first parameter toload_pem_x509_certificateisbytes, as there are code paths which pass this as a string (such ascrypto.from_keyspec -> crypto._load_keyspec -> crypto.XMLSecCryptoFromXML.__init__ -> crypto._cert_fingerprint).All Submissions: